chore: automate releases with release-please #2664
Conversation
|
flow:
For testing:
|
SgtPooki
changed the title
| @@ -2,8 +2,8 @@ | |||
|
|
|||
There was a problem hiding this comment.
the changes in this file are just changing repo strings from old ipfs-shipyard ones: s/ipfs-shipyard\/ipfs-desktop/ipfs\/ipfs-desktop/
| needs: [test, build] | ||
| if: github.ref == 'refs/heads/main' && (github.event_name == 'push' || github.event_name == 'workflow_dispatch') | ||
| steps: | ||
| - uses: google-github-actions/release-please-action@v3.7.3 |
There was a problem hiding this comment.
the release please action can run both of these steps based on different context.
i.e. it'll run the release-pr step when a release PR does not exist and then it'll create a release in the next step.
One obv. question will be how will plugin work, you can have a check in the plugin to validate if it's in the PR creation phase or release creation.
There was a problem hiding this comment.
the plugin is in the PR creation phase and already validated in #2672
There was a problem hiding this comment.
i'm not sure if the other issues you brought up need looked at.. we could just call npm run release-pr or npm run release-gh appropriately where we need to?
There was a problem hiding this comment.
does that also handle the tag-creation? combining steps simplifies maintainence.
| { | ||
| "bootstrap-sha": "ef61c998865ee90731e0bd495cc825a43c6fac60", | ||
| "group-pull-request-title-pattern": "chore${scope}: release${component} v${version}", | ||
| "extra-files": [], |
There was a problem hiding this comment.
I wonder if it would be nicer to use this entry to hook into in the plugin to make changes to the semver?
There was a problem hiding this comment.
extending extra-files to do what we needed to do would require changing the inner logic of their primary updater: https://github.com/googleapis/release-please/blob/main/src/updaters/generic.ts#L103
| "release-pr": "release-please release-pr --token=$GH_TOKEN --plugin '@ipfs-shipyard/release-please-ipfs-plugin' --repo-url=ipfs/ipfs-desktop --trace --debug --draft-pull-request", | ||
| "release-gh": "release-please github-release --token=$GH_TOKEN --repo-url=ipfs/ipfs-desktop --trace --debug --draft" |
There was a problem hiding this comment.
is this beneficial to have here?
There was a problem hiding this comment.
I think so.. having commands users can run easily (see developer-notes.md) is very beneficial
This PR enables release-please. some details at #2671 (comment)